-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(router): refactor hydration setting #31267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
tsapeta,
Kudo,
lukmccall,
ide,
brentvatne and
byCedric
as code owners
August 30, 2024 19:21
The Pull Request introduced fingerprint changes against the base commit: 122bbd1 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"bareRncliAutolinking"
],
"hash": "e874c37814b2ab83c29b6491dee49bab2fcaa357"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "d41f12937a1c30f8c9b0f37e1f33cc4956450e84"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "10b7ad626b7d668ef104804146cfbee64f9cdc9b"
}
}
] Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Aug 30, 2024
behenate
pushed a commit
that referenced
this pull request
Sep 30, 2024
# Why - We were completely invalidating the cache to change the rendering output mode. This was mostly just an artifact of when expo-router was in a different repo. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - I've refactored the hydration marker to not invalidate the cache at all or even go through Babel, we just inject it as a script global in the HTML during static rendering. - This is pulled out of the RSC branch. - I did notice however that we aren't enabling hydration in development at all. It appears to be broken on the suspense boundaries. We might not be able to fix this until we have RSC support enabled. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - E2E test for this will pass. - Dev works as expected. - Cache doesn't invalidate between output modes. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).