-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][iOS] Clean up ExpoModulesCore.podspec #31044
Conversation
The Pull Request introduced fingerprint changes against the base commit: df90d60 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "5c83c424bda454efb2cebcb5c21dccde1421d079"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "ios",
"reasons": [
"bareNativeDir"
],
"hash": "d6c2df3f5627709a916dc8bfac3acc837a857ffc"
}
}
] Generated by PR labeler 🤖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much appreciated for the change. leaving some comments for possibly improvements
"HEADER_SEARCH_PATHS" => user_header_search_paths, | ||
"HEADER_SEARCH_PATHS" => [ | ||
'"${PODS_CONFIGURATION_BUILD_DIR}/ExpoModulesCore/Swift Compatibility Header"', | ||
'"$(PODS_ROOT)/Headers/Private/Yoga"', # Expo.h -> ExpoModulesCore-umbrella.h -> Fabric ViewProps.h -> Private Yoga headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'"$(PODS_ROOT)/Headers/Private/Yoga"', # Expo.h -> ExpoModulesCore-umbrella.h -> Fabric ViewProps.h -> Private Yoga headers |
maybe we don't need Yoga because react-native core will add Yoga for modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, it fails on compiling AppDelegate.mm
– it can't find <yoga/style/Style.h>
🤔 I'll investigate this later and for now I would just go ahead and merge it as is.
798d2f9
to
bbc0308
Compare
Why
The podspec got a bit messy over time. Now we can include Fabric-specific code as Fabric pods are installed by default anyway.
How
pod ipc spec
was failing because we're requiring it after we calladd_dependency
)React-RCTFabric
dependency even if Fabric is not enabledios/Fabric
andcommon/fabric
foldersRN_FABRIC_ENABLED
withRCT_NEW_ARCH_ENABLED
Test Plan