[android][camera] Set the previews scaleType when changing ratio #30831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
commented
Aug 6, 2024
| @@ -394,7 +394,7 @@ export type CameraProps = ViewProps & { | |||
| responsiveOrientationWhenOrientationLocked?: boolean; | |||
| /** | |||
| * A string representing the aspect ratio of the preview. For example, `4:3` and `16:9`. | |||
| * @default 4:3 | |||
| * @default 1:1 | |||
There was a problem hiding this comment.
Default was set to 1:1 to maintain current behaviour.
|
The Pull Request introduced fingerprint changes against the base commit: 8b52504 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-camera/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "3b80516fc1fcaa90fc5e350a5f40b87ee10c1574"
}
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
Kudo
approved these changes
Aug 6, 2024
packages/expo-camera/android/src/main/java/expo/modules/camera/records/CameraRecords.kt
Outdated
Show resolved
Hide resolved
packages/expo-camera/android/src/main/java/expo/modules/camera/ExpoCameraView.kt
Show resolved
Hide resolved
Kudo
approved these changes
Aug 6, 2024
lukmccall
approved these changes
Aug 6, 2024
amandeepmittal
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #30829
When setting the aspect ratio, it will not take effect unless you also change the
scaleTypeon the preview. By default, it is set toFILL_CENTER, which ignores the aspect ratio setting and scales the image up to fill its container.How
Based on the ratio value, set the
scaleTypeof the previewView.Test Plan
Bare-expo. Changing ratios now affects the preview correctly.