[ios][modules-core] Fix getExternalPathPermissions returns no read/write permissions #30540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad/write permissions Function getExternalPathPermissions should use URL.path instead of URL.absoluteString to retrieve permissions using FileManager. For details see https://www.jessesquires.com/blog/2023/08/17/swift-url-absolutestring-path/
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Jul 22, 2024
tsapeta
changed the title
3 tasks
vonovak
pushed a commit
that referenced
this pull request
Jul 25, 2024
# Why Test introduced by this PR [#30540](#30540) fails on Android because `bundleDirectory` on Android has different structure and protocol. # How Enabled the test only for iOS platform. # Test Plan Run `FileSystem` tests using `bare-expo`. # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function getExternalPathPermissions should use
URL.pathinstead ofURL.absoluteStringto retrieve permissions using FileManager.For details see https://www.jessesquires.com/blog/2023/08/17/swift-url-absolutestring-path/
Why
Functions getPathPermissions, getExternalPathPermissions return no read/write permissions for any file
outside of "internal" directories: [cachesDirectory, documentDirectory, applicationSupportDirectory]
As the result FileSystem.copyAsync function throws an exception when attempting to copy asset files or files from the bundle directory.
How
Replaced
URL.absoluteStringwithURL.path.Test Plan
Use
FileSystem.copyAsyncmethod to copy any file from assets or bundle directories to a document directory.See a test added to
test-suite/tests/FileSystem.jsby this PR.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).