[ios][camera] Fix takePicture
in simulator
#30103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Close #29987
takePictureForSimulator
accepted aCameraViewLegacy
type as an argument which caused the wrong type of view to be passed to the AsyncFunction body. Because of this an error was thrown for an invalid number of arguments being passed to the legacy version oftakePicture
.How
Conform both new and legacy views to a protocol with the
onPictureSaved
dispatcher sotakePictureForSimulator
will accept either type of viewTest Plan
Bare expo on a physical device and simulator ✅