[cellular] Update cellular generation comments to specify HSPAP as 3G #30008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
requested review from
ide,
tsapeta,
Simek and
amandeepmittal
as code owners
amandeepmittal
approved these changes
Jun 25, 2024
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While working on some new features for expo-network I noticed that expo-cellular docs list HSPAP being returned as
4Gbut the actually code returns3Gexpo/packages/expo-cellular/android/src/main/java/expo/modules/cellular/CellularModule.kt
Lines 115 to 117 in 9000324
How
Update cellular generation comments to specify HSPAP as 3G and run
et generate-docs-api-dataTest Plan
Run docs locally
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).