fix(expo-contacts): #29198 store full url & remove useless restrictio… #29199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction on social profiles
mlecoq
force-pushed
the
fix_expoContactsUrlAndSocialProfiles
branch
from
9578503 to
afbf0fb
Compare
expo-bot
added
bot: passed checks
alanjhughes
approved these changes
May 30, 2024
alanjhughes
reviewed
May 31, 2024
alanjhughes
reviewed
May 31, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n on social profiles
Why
to fix #29198
How
I am using expo-contacts to store contacts and I have remarked that urls and social profiles are partially stored or missing
Test Plan
storing a contact with urls and social profiles
before modifications
after modifications
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).