[video-thumbnails][Android] Fix a crash when the source cannot be retrieved #28961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakesh0608
changed the title
expo-bot
added
bot: passed checks
tsapeta
reviewed
May 18, 2024
apps/native-component-list/src/navigation/ExpoComponentsStackNavigator.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/ExpoComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/VideoThumbnailsScreen.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/VideoThumbnailsScreen.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Sapeta <[email protected]>
Co-authored-by: Tomasz Sapeta <[email protected]>
Co-authored-by: Tomasz Sapeta <[email protected]>
tsapeta
approved these changes
May 20, 2024
tsapeta
changed the title
|
Do we know when this fix is going to be released to npm? I've patched my project's version of |
10 tasks
Hi @markrickert, |
|
@cristian0791 I don't have access to that client's source code anymore, but it should be relatively easy to make your own patch. just edit the two relevant files from this diff inside your node modules folder and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #27936
How
sourceFilename.sourceFilenameis valid, but the retriever can't load it due to a bad URI, then it throws an errorsetDataSource failed: status = 0x80000000. To handle this, a catch handler is added.Test Plan
Tested using bare-expo.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).