Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][Android] Make defaultAppContextMock private #28620

Merged

Conversation

lukmccall
Copy link
Contributor

Why

An improved version of the fixed proposed here: #28601.

How

To simplify our test setups, we should use the same set of mocks for each test case. Currently, we are using different mocks to start our tests in a few places, which is not scalable. Therefore, I suggest using a universal entry point to replace it.

Test Plan

  • unit tests ✅

@lukmccall lukmccall requested a review from alanjhughes May 4, 2024 09:22
@lukmccall lukmccall requested review from tsapeta and Kudo as code owners May 4, 2024 09:22
@expo-bot
Copy link
Collaborator

expo-bot commented May 4, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 61dedf6

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 4, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 4, 2024

The Pull Request introduced fingerprint changes against the base commit: 2d80ee3

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "671f29b417e63ac89c01110d2fa825fbad7be580"
  }
]

Generated by PR labeler 🤖

@lukmccall lukmccall merged commit 1fcceda into main May 4, 2024
21 of 22 checks passed
@lukmccall lukmccall deleted the @lukmccall/core/make-default-app-conetxt-mock-private branch May 4, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants