-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][Android] Make defaultAppContextMock
private
#28620
[core][Android] Make defaultAppContextMock
private
#28620
Conversation
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
The Pull Request introduced fingerprint changes against the base commit: 2d80ee3 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-modules-core/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "671f29b417e63ac89c01110d2fa825fbad7be580"
}
] Generated by PR labeler 🤖 |
Why
An improved version of the fixed proposed here: #28601.
How
To simplify our test setups, we should use the same set of mocks for each test case. Currently, we are using different mocks to start our tests in a few places, which is not scalable. Therefore, I suggest using a universal entry point to replace it.
Test Plan