[Android] Fix casting of Location.getCurrentPositionAsync#timeout param #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
requested changes
Oct 5, 2018
| async function getCurrentPositionAsync(options: { | ||
| timeout?: number, | ||
| enableHighAccuracy?: boolean, | ||
| maximumAge?: number, |
There was a problem hiding this comment.
why not as LocationOptions type?
There was a problem hiding this comment.
I've changed this, because I've added this timeout option, but I'll reverse it
|
I got no idea what is causing #2226 (comment). More specific info is needed here as I've never encountered such problem on testing devices. |
bbarthec
force-pushed
the
@bbarthec/location-getCurrentPositionAsync-timeout
branch
from
e13e2ef to
b314f99
Compare
esamelson
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
This looks good! It seems like #2226 (comment) is a separate issue (doesn't involve timeout) so let's not worry about it for this PR.
Reminder to add timeout to docs :)
bbarthec
force-pushed
the
@bbarthec/location-getCurrentPositionAsync-timeout
branch
from
b314f99 to
4d480cb
Compare
bbarthec
deleted the
@bbarthec/location-getCurrentPositionAsync-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #2226
How
Fixed casting issue