Fix face detector settings not being applied on first run #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
approved these changes
Oct 2, 2018
sjchmiela
force-pushed
the
@sjchmiela/fix_face_detector_android
branch
from
b15923b to
c0a24ea
Compare
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://expo-developers.slack.com/threads/convo/C04Q3JTSV-1534444938.000200/.
Long story short, props were being set before face detector has been initialized and thus the settings were being lost.
This PR makes Camera save pending face detector settings and apply to face detector when it's later initialized.