[media-library] Refactor to Kotlin 2 - Albums #14563
Conversation
barthap
force-pushed
the
@barthap/media-lib/kotlin/pt1-base
branch
from
3113c54 to
8300f8e
Compare
barthap
force-pushed
the
@barthap/media-lib/kotlin/pt2-albums
branch
from
7eaf56e to
0fe430b
Compare
| promise.reject(ERROR_MEDIA_LIBRARY_CORRUPTED, "Media library is corrupted") | ||
| return null | ||
| } | ||
| return File(fileInAlbum.parent!!) |
There was a problem hiding this comment.
Must the parent of the fileInAlbum exist?
There was a problem hiding this comment.
When it is a file (the if above), it must have a parent directory 😉
| internal fun interface AssetFileStrategy { | ||
| @Throws(IOException::class) | ||
| fun apply(src: File, dir: File, context: Context): File | ||
|
|
||
| companion object { | ||
| val copyStrategy = AssetFileStrategy { src, dir, _ -> MediaLibraryUtils.safeCopyFile(src, dir) } | ||
| val moveStrategy = AssetFileStrategy strategy@{ src, dir, context -> | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R && src is MediaLibraryUtils.AssetFile) { | ||
| val assetId = src.assetId | ||
| val assetUri = ContentUris.withAppendedId(MediaStore.Images.Media.EXTERNAL_CONTENT_URI, assetId.toLong()) | ||
| val newFile = MediaLibraryUtils.safeCopyFile(src, dir) | ||
| context.contentResolver.delete(assetUri, null) | ||
| return@strategy newFile | ||
| } | ||
| val newFile = MediaLibraryUtils.safeMoveFile(src, dir) | ||
| context.contentResolver.delete( | ||
| MediaLibraryConstants.EXTERNAL_CONTENT, | ||
| "${MediaStore.MediaColumns.DATA}=?", arrayOf(src.path) | ||
| ) | ||
| newFile | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I like the idea of putting implementation in the companion object in that case 💪
| return album | ||
| } | ||
|
|
||
| public override fun doInBackground(vararg params: Void?): Void? { |
There was a problem hiding this comment.
The type of this function looks stupid 😛 But we can't do anything with it right now.
barthap
force-pushed
the
@barthap/media-lib/kotlin/pt2-albums
branch
from
0fe430b to
aae9ecc
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
...es/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryUtils.java
Show resolved
Hide resolved
Why, How etc...
See #14562 description for details.
This is part of a PR stack:
expo.modules.medialibrary.albumspackage