Update isExpoPushToken type signature #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a better fit for what the function actually does: we don't know the type of the thing coming in, but we do know the type if it returns true. https://www.typescriptlang.org/docs/handbook/advanced-types.html#using-type-predicates
ide
reviewed
May 21, 2020
src/ExpoClient.ts
Outdated
| @@ -51,7 +51,7 @@ export class Expo { | |||
| /** | |||
| * Returns `true` if the token is an Expo push token | |||
| */ | |||
| static isExpoPushToken(token: ExpoPushToken): boolean { | |||
| static isExpoPushToken(token: any): token is ExpoPushToken { | |||
|
Awaiting feedback. Will close in a month if this goes stale. |
This forces us to check that the token is a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a better fit for what the function actually does: we don't know the type of the thing coming in, but we do know the type if it returns true.
https://www.typescriptlang.org/docs/handbook/advanced-types.html#using-type-predicates
note: I did this in GitHub's web interface so I didn't test if it compiles, although it should (famous last words)