This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
fix: make sharp image processing library an optional dependency #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
approved these changes
Jun 19, 2019
| }; | ||
|
|
||
| type Options = | ||
| | {} |
There was a problem hiding this comment.
TypeScript complained that {} is not compatible with Options. (The options for the removeAlpha operation are {}.)
|
|
||
| const SHARP_HELP_PATTERN = /\n\nSpecify --help for available options/g; | ||
|
|
||
| export async function sharpAsync( |
There was a problem hiding this comment.
Specify return values in TypeScript too?
| // Delete the optimized version and revert changes | ||
| fs.renameSync(newName, image); | ||
| if (amountSaved > 0) { | ||
| await fs.move(image, newName); |
There was a problem hiding this comment.
These operations should not happen in parallel – we first move the old file to filename.orig.ext and then move the optimized image from a temporary folder to its place.
fson
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Installing the
sharpimage processing library can fail for a few resons:node_modulesfolder. Cannot install expo-cli global (windows 10) #650 I can not install here, Ubuntu 18.04.2 #613 Expo CLI cant be installed in Linux #591 Can't install expo-cli #590When sharp installation fails, previously the whole Expo CLI installation has failed.
How
To make it possible to install Expo CLI without
sharp, this PR makessharpan optional dependency (via thesharp-clipackage). Only certain functionality (expo optimizeand web builds) requiresharp.For most users sharp will be installed without problems, and those users will be able to use all features without any additional setup.
Those users who previously had problems installing
sharpwill continue to see warnings when installing but because the dependency is now optional, it won’t fail the whole installation. They will also be able to use Expo CLI. When trying to use functionality that requiressharp, Expo CLI will prompt themto separately install the
sharp-clipackage globally. Aftersharp-cliis installed, those commands can be used.Further improvements
In the future, we could make our own distribution of sharp to fix the permissions issues (using the same method we use for ngrok and traveling fastlane). Additionally we could provide JS-only fallbacks (even if they’re slower) for platforms that sharp doesn’t support.