fix SMS TFA for Apple authentication #2750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Apple changed their auth servers for the SMS endpoint to seemingly geotag sms requests to American devices. This caused the error "Verification codes can’t be sent to this phone number at this time. Please try again later." to be thrown when requesting two-factor authentication with an SMS device.
This PR, in addition to a few others, aims to align the API such that SMS codes can successfully be sent to American phone numbers. I can only verify 4 times every hour, so this may only partially fix the issue.
Test Plan
eas build -p ios
-> login -> Picksms
for the 2fa.