Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SMS TFA for Apple authentication #2750

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

Apple changed their auth servers for the SMS endpoint to seemingly geotag sms requests to American devices. This caused the error "Verification codes can’t be sent to this phone number at this time. Please try again later." to be thrown when requesting two-factor authentication with an SMS device.

This PR, in addition to a few others, aims to align the API such that SMS codes can successfully be sent to American phone numbers. I can only verify 4 times every hour, so this may only partially fix the issue.

Test Plan

eas build -p ios -> login -> Pick sms for the 2fa.

Copy link

github-actions bot commented Dec 9, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 9, 2024

✅ Thank you for adding the changelog entry!

Copy link

github-actions bot commented Dec 9, 2024

Size Change: -365 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -365 B (0%)

compressed-size-action

@szdziedzic szdziedzic merged commit dcb1305 into main Dec 9, 2024
7 checks passed
@szdziedzic szdziedzic deleted the @evanbacon/eas-cli/fix-sms-tfa branch December 9, 2024 19:53
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.49%. Comparing base (97fe2d6) to head (17289c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2750   +/-   ##
=======================================
  Coverage   52.49%   52.49%           
=======================================
  Files         583      583           
  Lines       22556    22556           
  Branches     4438     4438           
=======================================
  Hits        11839    11839           
  Misses      10682    10682           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants