Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-14223][eas-cli] improve class names and descriptions of env commands #2711

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 20, 2024

Why

Make class names more consistent with other commands

Improve descriptions

How

Make class names more consistent with other commands

Improve descriptions

Test Plan

Tests

Copy link

linear bot commented Nov 20, 2024

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review November 20, 2024 16:16
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

Copy link

github-actions bot commented Nov 20, 2024

Size Change: +191 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +191 B (0%)

compressed-size-action

@szdziedzic szdziedzic force-pushed the 11-20-_eng-14223_eas-cli_improve_class_names_and_descriptions_of_env_commands branch from 303dd72 to e2d65d9 Compare November 20, 2024 16:47
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic merged commit fc3c1e7 into main Nov 20, 2024
7 of 8 checks passed
@szdziedzic szdziedzic deleted the 11-20-_eng-14223_eas-cli_improve_class_names_and_descriptions_of_env_commands branch November 20, 2024 16:51
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (bb3915d) to head (e2d65d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 50.00% 2 Missing ⚠️
packages/eas-cli/src/commands/env/push.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2711   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files         579      579           
  Lines       22194    22194           
  Branches     4343     4343           
=======================================
  Hits        11710    11710           
  Misses      10448    10448           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants