Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] pass on fingerprint info on republish #2708

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Nov 20, 2024

Why

This PR adds support for fingerprint information in update republishing workflows. If the republished update has fingerprint info, we include it.

Before landing

How

  • Added fingerprint fields to the GraphQL schema and related types
  • Updated the Update fragment to include fingerprint information (id, hash, and source details)
  • Modified the republish functionality to include fingerprint information when republishing updates
  • Added support for fingerprint source types and bucket key information

Test Plan

Copy link
Member Author

quinlanj commented Nov 20, 2024

Copy link

github-actions bot commented Nov 20, 2024

Size Change: -2.52 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.52 kB (0%)

compressed-size-action

@quinlanj quinlanj marked this pull request as ready for review November 20, 2024 02:36
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/update/** @EvanBacon, @byCedric, @wschurman

Generated by CodeMention

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (fc3c1e7) to head (e26d94e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/update/republish.ts 57.15% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
+ Coverage   52.77%   52.80%   +0.03%     
==========================================
  Files         579      580       +1     
  Lines       22194    22269      +75     
  Branches     4343     4355      +12     
==========================================
+ Hits        11710    11756      +46     
- Misses      10448    10477      +29     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@quinlanj quinlanj force-pushed the 11-12-_eas-cli_create_fingerprint_on_each_update branch from 1149b96 to 2527a31 Compare November 20, 2024 21:23
@quinlanj quinlanj force-pushed the 11-19-_eas-cli_pass_on_fingerprint_info_on_republish branch from 94c1415 to 1035622 Compare November 20, 2024 21:24
@quinlanj quinlanj force-pushed the 11-12-_eas-cli_create_fingerprint_on_each_update branch from 2527a31 to 9eb89a7 Compare November 20, 2024 21:32
@quinlanj quinlanj force-pushed the 11-19-_eas-cli_pass_on_fingerprint_info_on_republish branch from 1035622 to a16fa1c Compare November 20, 2024 21:32
@quinlanj quinlanj changed the base branch from 11-12-_eas-cli_create_fingerprint_on_each_update to graphite-base/2708 November 20, 2024 21:43
@quinlanj quinlanj force-pushed the 11-19-_eas-cli_pass_on_fingerprint_info_on_republish branch from a16fa1c to e92ee6b Compare November 20, 2024 21:43
@quinlanj quinlanj changed the base branch from graphite-base/2708 to main November 20, 2024 21:43
@quinlanj quinlanj force-pushed the 11-19-_eas-cli_pass_on_fingerprint_info_on_republish branch from e92ee6b to e26d94e Compare November 20, 2024 21:44
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit ec71e11 into main Nov 20, 2024
4 checks passed
Copy link
Member Author

Merge activity

  • Nov 20, 4:44 PM EST: A user merged this pull request with Graphite.

@quinlanj quinlanj deleted the 11-19-_eas-cli_pass_on_fingerprint_info_on_republish branch November 20, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants