-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eas-cli): update EAS Metadata with new props for App Store 3.6.0 #2671
fix(eas-cli): update EAS Metadata with new props for App Store 3.6.0 #2671
Conversation
Subscribed to pull request
Generated by CodeMention |
94d711d
to
2e01de9
Compare
Size Change: +5.76 kB (+0.01%) Total Size: 52.7 MB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work here, very slick
✅ Thank you for adding the changelog entry! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
==========================================
+ Coverage 52.92% 52.93% +0.01%
==========================================
Files 570 570
Lines 21862 21866 +4
Branches 4302 4306 +4
==========================================
+ Hits 11568 11572 +4
Misses 10260 10260
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Why
This changes a few properties from
apple.advisory.*
object in the store config. It's just an update to keep up with Apple's changes on the App Store.seventeenPlus
- Dropped in favor ofageRatingOverride
ageRatingOverride
- New property to override the standard age ratingkoreaAgeRatingOverride
- Same asageRatingOverride
, but for South KoreaIf you see this, you can upgrade to use this new format:
eas metadata:pull
Make sure you don't have any local changes, as this command will override your local store config.
How
@expo/[email protected]
Test Plan
Both command should work fine for any listed app.
eas metadata:pull
eas metadata:push