Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eas-cli): update EAS Metadata with new props for App Store 3.6.0 #2671

Merged

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Nov 5, 2024

Why

This changes a few properties from apple.advisory.* object in the store config. It's just an update to keep up with Apple's changes on the App Store.

  • seventeenPlus - Dropped in favor of ageRatingOverride
  • ageRatingOverride - New property to override the standard age rating
  • koreaAgeRatingOverride - Same as ageRatingOverride, but for South Korea

If you see this, you can upgrade to use this new format:

  • eas metadata:pull

Yep, that's it.

Make sure you don't have any local changes, as this command will override your local store config.

How

Test Plan

Both command should work fine for any listed app.

  • eas metadata:pull
  • eas metadata:push

Copy link

github-actions bot commented Nov 5, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/schema/** @byCedric
packages/eas-cli/src/metadata/** @byCedric

Generated by CodeMention

@byCedric byCedric force-pushed the @bycedric/eas-metadata/upgrade-metadata-to-appstore-3.6.0 branch from 94d711d to 2e01de9 Compare November 5, 2024 21:39
Copy link

github-actions bot commented Nov 5, 2024

Size Change: +5.76 kB (+0.01%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB +5.76 kB (+0.01%)

compressed-size-action

Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work here, very slick

Copy link

github-actions bot commented Nov 5, 2024

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.93%. Comparing base (433c47b) to head (5ae6e91).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
+ Coverage   52.92%   52.93%   +0.01%     
==========================================
  Files         570      570              
  Lines       21862    21866       +4     
  Branches     4302     4306       +4     
==========================================
+ Hits        11568    11572       +4     
  Misses      10260    10260              
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 281ae7b into main Nov 5, 2024
10 checks passed
@byCedric byCedric deleted the @bycedric/eas-metadata/upgrade-metadata-to-appstore-3.6.0 branch November 5, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants