Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording in env:pull command #2655

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-13928: Update "secret" with "encrypted" on eas env:pull

The message informing user about encrypted variables omission can be clearer.

image

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

Copy link

linear bot commented Oct 24, 2024

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela

Generated by CodeMention

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Size Change: -483 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -483 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (5478814) to head (67ce5d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   52.91%   52.91%           
=======================================
  Files         570      570           
  Lines       21750    21750           
  Branches     4263     4263           
=======================================
  Hits        11506    11506           
  Misses      10213    10213           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13928-update-secret-with-encrypted-on-eas-envpull branch from b1914d7 to edcab02 Compare October 25, 2024 16:57
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13928-update-secret-with-encrypted-on-eas-envpull branch from edcab02 to 67ce5d2 Compare October 25, 2024 17:06
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@khamilowicz khamilowicz merged commit 3e6cf78 into main Oct 25, 2024
7 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13928-update-secret-with-encrypted-on-eas-envpull branch October 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants