-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] add simplified projectId-focused context #2653
[eas-cli] add simplified projectId-focused context #2653
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @szdziedzic and the rest of your teammates on Graphite |
Subscribed to pull request
Generated by CodeMention |
Size Change: -3.46 kB (-0.01%) Total Size: 53 MB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
a4dd89c
to
69858a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
==========================================
- Coverage 52.93% 52.93% -0.00%
==========================================
Files 569 570 +1
Lines 21722 21740 +18
Branches 4259 4260 +1
==========================================
+ Hits 11497 11505 +8
- Misses 10194 10204 +10
Partials 31 31 ☔ View full report in Codecov by Sentry. |
d586efc
to
9e9575d
Compare
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Why
As suggested in the base PR we need a simple context focused on only getting the project ID, without specifying the server-side environment and resolving Expo config with it.
How
Add such context. Make the
withServerSideEnvironment
argument required for standard project config context.Test Plan
Tests, test manually