Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add simplified projectId-focused context #2653

Merged

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Oct 24, 2024

Why

As suggested in the base PR we need a simple context focused on only getting the project ID, without specifying the server-side environment and resolving Expo config with it.

How

Add such context. Make the withServerSideEnvironment argument required for standard project config context.

Test Plan

Tests, test manually

Copy link
Member Author

szdziedzic commented Oct 24, 2024

Copy link

github-actions bot commented Oct 24, 2024

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/build/** @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/submit.ts @khamilowicz, @sjchmiela, @radoslawkrzemien
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric, @wschurman
packages/eas-cli/src/commands/metadata/** @byCedric

Generated by CodeMention

Copy link

github-actions bot commented Oct 24, 2024

Size Change: -3.46 kB (-0.01%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -3.46 kB (-0.01%)

compressed-size-action

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@szdziedzic szdziedzic force-pushed the 10-24-_eas-cli_add_simplified_projectid-focused_context branch from a4dd89c to 69858a4 Compare October 25, 2024 11:27
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (d0f01cb) to head (9e9575d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dUtils/context/PrivateProjectConfigContextField.ts 22.23% 7 Missing ⚠️
.../src/commandUtils/context/ProjectIdContextField.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
- Coverage   52.93%   52.93%   -0.00%     
==========================================
  Files         569      570       +1     
  Lines       21722    21740      +18     
  Branches     4259     4260       +1     
==========================================
+ Hits        11497    11505       +8     
- Misses      10194    10204      +10     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

szdziedzic commented Oct 25, 2024

Merge activity

  • Oct 25, 8:18 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 25, 8:20 AM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@szdziedzic szdziedzic changed the base branch from 10-17-_eas-cli_add_--with-eas-environment-variables-set_flag_to_eas_update_command to graphite-base/2653 October 25, 2024 12:19
@szdziedzic szdziedzic changed the base branch from graphite-base/2653 to main October 25, 2024 12:19
@szdziedzic szdziedzic force-pushed the 10-24-_eas-cli_add_simplified_projectid-focused_context branch from d586efc to 9e9575d Compare October 25, 2024 12:22
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic merged commit 8c05a71 into main Oct 25, 2024
10 of 11 checks passed
@szdziedzic szdziedzic deleted the 10-24-_eas-cli_add_simplified_projectid-focused_context branch October 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants