Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Disallow republishing an update that is being rolled-out #2602

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Sep 26, 2024

Why

What it means to republish an update that is being rolled-out is undefined behavior. Rather than try to guess at the user's intent, just throw an error in this case and give guidance about other options to help them clarify intent.

Note that this doesn't hide the groups during interactive chooser, since that'd be even more confusing IMO.

Closes ENG-13613.

How

Throw error when any update being republished is a rollout update.

Test Plan

$ neas update:republish --branch main
✔ Load more update groups? › [Aug 19 16:23 by wschurman, runtimeVersion: 1.0.0] wat2
✔ The republished update group will appear only on: all
✔ Provide an update message. … dsadsasd
Cannot republish an update that is being rolled-out. Either complete the update rollout and then republish or publish a new rollout update.
    Error: update:republish command failed.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman force-pushed the @wschurman/09-26-_eas-cli_disallow_republishing_an_update_that_is_being_rolled-out branch from 86d4cbf to 4da949d Compare September 26, 2024 16:51
Copy link

github-actions bot commented Sep 26, 2024

Size Change: +703 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +703 B (0%)

compressed-size-action

Copy link

linear bot commented Sep 26, 2024

@wschurman wschurman marked this pull request as ready for review September 26, 2024 16:58
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.87%. Comparing base (ffa2f03) to head (2b0350e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
+ Coverage   51.87%   51.87%   +0.01%     
==========================================
  Files         563      563              
  Lines       21301    21303       +2     
  Branches     4348     4348              
==========================================
+ Hits        11047    11049       +2     
  Misses       9366     9366              
  Partials      888      888              
Flag Coverage Δ
51.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj
Copy link
Member

would be nice to add server side guards for this in case we havent already

Copy link
Member Author

wschurman commented Sep 27, 2024

would be nice to add server side guards for this in case we havent already

A republish is just a normal publish, so there isn't a way to detect a republish on the server. (I think this is good and by design though, one less concept to keep track of)

@wschurman wschurman force-pushed the @wschurman/09-26-_eas-cli_disallow_republishing_an_update_that_is_being_rolled-out branch from 4da949d to 2b0350e Compare September 27, 2024 16:04
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 6823e4f into main Sep 27, 2024
6 checks passed
@wschurman wschurman deleted the @wschurman/09-26-_eas-cli_disallow_republishing_an_update_that_is_being_rolled-out branch September 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants