-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Disallow republishing an update that is being rolled-out #2602
[eas-cli] Disallow republishing an update that is being rolled-out #2602
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on Graphite |
86d4cbf
to
4da949d
Compare
Size Change: +703 B (0%) Total Size: 52.9 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
==========================================
+ Coverage 51.87% 51.87% +0.01%
==========================================
Files 563 563
Lines 21301 21303 +2
Branches 4348 4348
==========================================
+ Hits 11047 11049 +2
Misses 9366 9366
Partials 888 888
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
would be nice to add server side guards for this in case we havent already |
A republish is just a normal publish, so there isn't a way to detect a republish on the server. (I think this is good and by design though, one less concept to keep track of) |
4da949d
to
2b0350e
Compare
✅ Thank you for adding the changelog entry! |
Why
What it means to republish an update that is being rolled-out is undefined behavior. Rather than try to guess at the user's intent, just throw an error in this case and give guidance about other options to help them clarify intent.
Note that this doesn't hide the groups during interactive chooser, since that'd be even more confusing IMO.
Closes ENG-13613.
How
Throw error when any update being republished is a rollout update.
Test Plan