refactor(eas-cli): allow Expo Router server deployments without client directory

[byCedric]

Why

Previously, we checked on the existence of both /dist/client and /dist/server to enable a deployment for API routes. With upcoming changes in Expo Router, we'd need to support a "server only" deployment. This means, we can't check /dist/client as it might not exist.

How

• Check on /dist/server/_expo/routes.json to enable server deployments
• Make /dist/client optional during upload

Test Plan

• $ bun create expo ./test-server-only
• $ cd ./test-server-only
• Create an API route, e.g. app/test+api.ts with:

  export function GET() {
    return Response.json({ ok: true });
  }

• Change the output type to server in app.json's web.output = server.
• $ rm -rf ./dist/client
• $ easd deploy

[github-actions]

✅ Thank you for adding the changelog entry!

[github-actions]

Size Change: -501 B (0%)

Total Size: 52.9 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	52.9 MB	-501 B (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.99%. Comparing base (c0c2755) to head (88e12d3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/eas-cli/src/commands/worker/deploy.ts	0.00%	5 Missing and 3 partials ⚠️
packages/eas-cli/src/worker/assets.ts	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   52.00%   51.99%   -0.01%     
==========================================
  Files         562      562              
  Lines       21194    21199       +5     
  Branches     4335     4338       +3     
==========================================
  Hits        11020    11020              
- Misses       9292     9294       +2     
- Partials      882      885       +3     

Flag	Coverage Δ
	51.99% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[byCedric]

@kitten the "wait until the deployment is ready before responding that the deployment is ready"-thing broke again with this change 🙈

When there is no /dist/client dir, we skip uploading assets. Because of that, the promote to prod is hitting faster than the server actually stores in the DB. What do you think is the best option here?

• Let the server process the thing before responding
• Retry the promote if there is a 404 in the CLI

[kitten]

Approving since implementation itself is fine.

Re. the timing issue, this ticket would resolve these problems for sure: https://linear.app/expo/issue/ENG-13544/implement-closing-request-for-upload-logic

But weirdly enough, I can't spot any deferred logic in here that would otherwise cause this. So, not sure why this timing issue is happening

[byCedric]

The mystery has been solved by @kitten, it's pending merge & deploy. Going to merge this PR as is; the erroneous case should be fixed by the pending PR.