Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): simplify the output of eas deploy --json #2596

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

byCedric
Copy link
Member

Why

The initial version was a bit conservative, nesting objects to not mix dashboardUrl with deployments. This change flattens the deployment object into the root object when running with --json.

How

  • Flattened the deployment object into the root object when running eas deploy --json

Test Plan

image

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: -2.06 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.06 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (2e002ad) to head (4ac8777).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/utils/logs.ts 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
- Coverage   52.01%   52.00%   -0.01%     
==========================================
  Files         562      562              
  Lines       21189    21194       +5     
  Branches     4332     4335       +3     
==========================================
  Hits        11020    11020              
- Misses       9288     9292       +4     
- Partials      881      882       +1     
Flag Coverage Δ
52.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit c0c2755 into main Sep 24, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/worker/simplify-json-output branch September 24, 2024 14:45
khamilowicz pushed a commit that referenced this pull request Sep 27, 2024
* refactor(eas-cli): simplify the `eas deploy --json` output

* docs: fix changelog entry

* refactor(eas-cli): keep aliases as array in `--json` output

* docs: fix changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants