Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): support assigning dev domain in non interactive mode #2595

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 24, 2024

Why

When running eas worker --non-interactive, it aborts on the first deployment due to a missing dev domain name. This changes that by automatically assigning the suggested dev domain when running in non interactive mode.

How

  • Split out prompting dev domain from assigning dev domain
  • Automatically assign the suggested dev domain when running in non interactive mode

Test Plan

Test the auto-assignment of the dev domain

  • $ export EXPO_STAGING=1
  • $ bun create expo ./test-auto-assign
  • $ cd ./test-auto-assign
  • $ bun expo export --platform web
  • $ easd init
  • $ easd deploy --non-interactive
Example

image

Test the manual assignment of the dev domain

  • $ export EXPO_STAGING=1
  • $ bun create expo ./test-manual-assign
  • $ cd ./test-manual-assign
  • $ bun expo export --platform web
  • $ easd init
  • $ easd deploy
Example

image

Copy link

github-actions bot commented Sep 24, 2024

Size Change: -678 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -678 B (0%)

compressed-size-action

@byCedric byCedric force-pushed the @bycedric/worker/support-non-interactive-dev-domain branch from 1651c7e to 9a619e7 Compare September 24, 2024 12:16
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (2e002ad) to head (e160e21).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/deployment.ts 7.70% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   52.01%   52.00%   -0.01%     
==========================================
  Files         562      562              
  Lines       21189    21195       +6     
  Branches     4332     4334       +2     
==========================================
+ Hits        11020    11021       +1     
- Misses       9288     9293       +5     
  Partials      881      881              
Flag Coverage Δ
52.00% <7.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 0863b9a into main Sep 26, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/worker/support-non-interactive-dev-domain branch September 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants