Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Let iOS bundle identifier override always #2576

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Sep 18, 2024

Why

In a submit job we're going to have an IPA/APK to submit. We don't want to resolve any bundle identifiers from the project, we can use one from that IPA/APK.

How

Let the override env variable override bundle identifier resolution if the workflow is managed too.

Test Plan

I used it to submit an IPA with workflows.

Copy link

github-actions bot commented Sep 18, 2024

Size Change: -376 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -376 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.12%. Comparing base (d33ebe1) to head (9695bcd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kages/eas-cli/src/project/android/applicationId.ts 50.00% 1 Missing ⚠️
...ckages/eas-cli/src/project/ios/bundleIdentifier.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2576   +/-   ##
=======================================
  Coverage   52.12%   52.12%           
=======================================
  Files         559      559           
  Lines       21111    21111           
  Branches     4317     4317           
=======================================
  Hits        11003    11003           
  Misses       9230     9230           
  Partials      878      878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela
Copy link
Contributor Author

/changelog-entry new-feature Let application ID overrides work in any workflow, not only in bare workflow.

Copy link

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit 2cf6dd4 into main Sep 19, 2024
9 checks passed
@sjchmiela sjchmiela deleted the sjchmiela-patch-1 branch September 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants