Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-11823][2/2] move credentials endpoints to paginated #2327

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Apr 13, 2024

Why

Move credentials endpoints to their better paginated counterparts.

How

Affects dist cert, asc api keys, apple devices and push key fetching

Test Plan

Tested userflows which rely on

  • fetching asc api keys ( < 1 page and multiple pages)
  • fetching dist certs ( < 1 page and multiple pages)
  • apple devices ( < 1 page and multiple pages)
  • push key fetching ( < 1 page and multiple pages)
  • google service account key fetching ( < 1 page and multiple pages)

@quinlanj quinlanj changed the title [1/2] move credentials endpoints to paginated [2/2] move credentials endpoints to paginated Apr 13, 2024
Copy link

github-actions bot commented Apr 13, 2024

Size Change: +7.41 kB (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +7.41 kB (0%)

compressed-size-action

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 12.76596% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 53.67%. Comparing base (a8cde5e) to head (726b5f3).

Files Patch % Lines
...ntials/ios/api/graphql/queries/AppleDeviceQuery.ts 5.89% 15 Missing and 1 partial ⚠️
...pi/graphql/queries/GoogleServiceAccountKeyQuery.ts 14.29% 6 Missing ⚠️
.../api/graphql/queries/AppStoreConnectApiKeyQuery.ts 14.29% 6 Missing ⚠️
...aphql/queries/AppleDistributionCertificateQuery.ts 14.29% 6 Missing ⚠️
...tials/ios/api/graphql/queries/ApplePushKeyQuery.ts 14.29% 6 Missing ⚠️
...rc/devices/actions/create/developerPortalMethod.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2327      +/-   ##
==========================================
- Coverage   53.73%   53.67%   -0.06%     
==========================================
  Files         525      525              
  Lines       19226    19256      +30     
  Branches     4061     4062       +1     
==========================================
+ Hits        10330    10334       +4     
- Misses       8171     8197      +26     
  Partials      725      725              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj
Copy link
Member Author

/changelog-entry bug-fix move credentials endpoints to paginated counterparts

@quinlanj quinlanj marked this pull request as ready for review April 13, 2024 03:04
@quinlanj quinlanj force-pushed the @quin/pagination-1 branch from 0742d84 to ae95a26 Compare April 13, 2024 03:26
@quinlanj quinlanj changed the title [2/2] move credentials endpoints to paginated [ENG-11823][2/2] move credentials endpoints to paginated Apr 13, 2024
Copy link

linear bot commented Apr 13, 2024

@quinlanj
Copy link
Member Author

/changelog-entry bug-fix move credentials endpoints to paginated counterparts

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@quinlanj quinlanj force-pushed the @quin/pagination-1 branch from 8af71c9 to 726b5f3 Compare April 15, 2024 17:13
@quinlanj quinlanj changed the base branch from @quin/p-0-frozen to main April 15, 2024 17:13
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit c8313f3 into main Apr 15, 2024
9 checks passed
@quinlanj quinlanj deleted the @quin/pagination-1 branch April 15, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants