Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] stop querying Build.resourceClass #2320

Merged
merged 2 commits into from
Apr 11, 2024
Merged

[eas-cli] stop querying Build.resourceClass #2320

merged 2 commits into from
Apr 11, 2024

Conversation

szdziedzic
Copy link
Member

Why

This field is not used anywhere and we want to delete it from WWW in the future.

How

stop querying Build.resourceClass

Test Plan

Tests

sjchmiela
sjchmiela approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. If these are the only changes required I think we should be able to simplify Build.resourceClass in www.

@szdziedzic
Copy link
Member Author

/changelog-entry chore Stop querying Build.resourceClass field

@github-actions GitHub Actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions GitHub Actions
Copy link

Size Change: -936 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -936 B (0%)

compressed-size-action

@szdziedzic szdziedzic merged commit d6186ed into main Apr 11, 2024
6 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/stop-using-querying-build-resource-class-in-cli branch April 11, 2024 09:45
@arenault-pass arenault-pass mentioned this pull request Jul 31, 2024
Closed
This was referenced Sep 9, 2024
Closed
Closed
This was referenced Sep 17, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela approved these changes

@khamilowicz khamilowicz Awaiting requested review from khamilowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szdziedzic @sjchmiela