Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] fix asset limit punctuation #2296

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[eas-cli] fix asset limit punctuation #2296

merged 2 commits into from
Mar 21, 2024

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Mar 21, 2024

Why

nit: there is a . before the : when printing out the line about asset limits

before

image (5)

after

Screenshot 2024-03-21 at 12 09 31 PM

Test Plan

  • manually inspected

@quinlanj
Copy link
Member Author

/changelog-entry chore fix asset limit punctuation

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: +533 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +533 B (0%)

compressed-size-action

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.96%. Comparing base (08ea07b) to head (40d8e21).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2296   +/-   ##
=======================================
  Coverage   53.96%   53.96%           
=======================================
  Files         520      520           
  Lines       18993    18993           
  Branches     4010     4010           
=======================================
  Hits        10248    10248           
  Misses       8032     8032           
  Partials      713      713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj merged commit eec975c into main Mar 21, 2024
9 checks passed
@quinlanj quinlanj deleted the @quin/fix-asset-print branch March 21, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants