-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] fix asset limit punctuation #2296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinlanj
requested review from
EvanBacon,
byCedric and
wschurman
as code owners
March 21, 2024 19:12
/changelog-entry chore fix asset limit punctuation |
quinlanj
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
March 21, 2024 19:14
✅ Thank you for adding the changelog entry! |
Size Change: +533 B (0%) Total Size: 51.3 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 53.96% 53.96%
=======================================
Files 520 520
Lines 18993 18993
Branches 4010 4010
=======================================
Hits 10248 10248
Misses 8032 8032
Partials 713 713 ☔ View full report in Codecov by Sentry. |
brentvatne
approved these changes
Mar 21, 2024
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
nit: there is a
.
before the:
when printing out the line about asset limitsbefore
after
Test Plan