Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClearMLLogger.v2 #22

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Jan 3, 2023

Description

This PR refactors commonly reused code into separate functions and adds ClearMLLogger.v2.

v2 changes/adds the following:

  • The logger no longer calls the console logger internally. To avail oneself of both, the ChainLogger needs to be used as the main logger.
  • log_custom_stats has been added as a new optional parameter, which is a list of regexps. Keys in the info dictionary that match any of these regexps are automatically logged to ClearML.

Types of change

Refactor/New feature

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Add `v2` to support custom stats logging and `ChainLogger`
@shadeMe shadeMe added the enhancement New feature or request label Jan 3, 2023
@rmitsch rmitsch mentioned this pull request Jan 3, 2023
3 tasks
spacy_loggers/clearml.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spacy_loggers/clearml.py Outdated Show resolved Hide resolved
spacy_loggers/clearml.py Outdated Show resolved Hide resolved
@shadeMe shadeMe merged commit 6c0fea5 into explosion:main Jan 4, 2023
@shadeMe shadeMe deleted the feat/custom-stats-clearml branch January 4, 2023 10:51
@tpanza tpanza mentioned this pull request Aug 16, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants