-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy v2.0.0 breaks the ability to download models using spaCy #13528
Comments
+1 |
this solution helped, thank you |
+1 I also had this problem. Thanks for posting the solution 👍 |
Those solutions indeed works, but I would still like to see a fix in the codebase itself. This issue is that inside the numpy>=1.15.0; python_version < "3.9"
numpy>=1.19.0; python_version >= "3.9" I am a huge fan, in all of my projects, of always pinning dependencies even up to the patch version. I would suggest a PR that looks like this: numpy>=1.15.0,<2.0.0; python_version < "3.9"
numpy>=1.19.0,<2.0.0; python_version >= "3.9" This at least pins the version down to major releases, which should anyway always be the case, as major version can (and most likely will always) contain breaking changes. |
@DoctorManhattan123 To clarify, the solution I posted is only meant to be a stopgap. Ideally, all downstream consumers of numpy (including library maintainers) should complete the migration to leverage numpy 2.0.0. I imagine, given the size of the release, that this will take time. The pinned version is to tide over people seeking to quickly fix their CI/CD or whatever impacted process is broken until a more robust solution is implemented in the affected codebases. |
This issue with thinc has been noted explosion/thinc#939 |
there is a spaCy bug that hopefully will be fixed soon: explosion/spaCy#13528
spacy is not compatible with numpy 2.x, see: explosion/spaCy#13528 and thus the CI fails locking numpy to latest 1.x release fixes this problem Signed-off-by: SoulHarsh007 <[email protected]>
It helped. Thanks! |
The new release 3.7.6 should resolve this :) |
I'm still experiencing the same error on 3.7.6 and numpy 2.1 && 2.0.0. As a sanity check it works after downgrading to 1.26.4 |
The issue still persists with the |
Yes it appears The latest release before that ( |
See also #13607 |
Sorry for the delay on this. I want to release the upgraded numpy pin as version 3.8, because I don't want to drop support for Python 3.8 in a patch release. Upgrading to numpy v2 in a patch release is also questionable. However, the model artifacts bake in the version of spaCy into the package. This means I need to retrain the models to do the v3.8 release, and the retraining is taking some time. |
@honnibal I think this was resolved by release 3.8.2, right? If so, can we close? |
@afogel still happens to me on 3.8.2 |
How to reproduce the behaviour
In my dockerfile, I run these commands:
It returns the following error (and stacktrace):
Locking to the previous version of numpy will resolve this issue:
The text was updated successfully, but these errors were encountered: