Problem importing celery to enable tasks #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #493 Rename test project celery file to avoid clash with celery package
Issue #493 Add presigned url setting Added utility method to convert csv file object to BytesIO for boto
Issue #493 Get presigned urls for snapshots
Issue #493 Fix test for presigned urls
Issue #493 Revert unneeded change to json exporter
Issue #493 Pin importlib-metadata to <5.0 for python < 3.7 to avoid celery import error python/importlib_metadata#411
|
@marksweb just checking if any tweaks I need to make to this PR? Thanks! |
|
@lawson89 Sorry, I'd forgotten about this. I will continue my review tomorrow. |
marksweb
approved these changes
Dec 1, 2022
|
@lawson89 I've just got finished with pre-commit hooks. Now this does bring some conflicts with your work here - sorry about that - but I wanted to get these hooks in before any more changes come in. Could you take a look at updating your branch and resolving please? |
Issue #493 Rename test project celery file to avoid clash with celery package
Issue #493 Add presigned url setting Added utility method to convert csv file object to BytesIO for boto
Issue #493 Get presigned urls for snapshots
Issue #493 Fix test for presigned urls
Issue #493 Revert unneeded change to json exporter
Issue #493 Pin importlib-metadata to <5.0 for python < 3.7 to avoid celery import error python/importlib_metadata#411
… feature/celery_boto_update # Conflicts: # explorer/tasks.py # test_project/settings.py
|
@lawson89 There's just some linting issues to resolve. You could get isort to fix the imports itself with |
|
Yep - will take care of those in just a bit |
Issue #493 Fix isort and formatting issues
marksweb
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #493