-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EXPLORER_SCHEMA_EXCLUDE_TABLE_PREFIXES #368
Conversation
66f9753
to
7212829
Compare
7212829
to
754a197
Compare
I thought about excluding |
@chrisclark hey :-) |
looks reasonable to me. Merging, thanks for the PR @ramonsaraiva! |
Looks like this should be reverted as it now fails RST file validation:
|
I don't quite understand that error.. |
Part of the pypi upload process involved validation against the README.rst file, that validation failed when the prefixes were not fully defined like |
The table prefixes are in fact Not sure what process is validating the README file but I don't understand why having |
I would try running the README.rst with your changes in it against an RST validator (like this one https://pypi.org/project/rstvalidator/). it throws the same "unknown target name" error. After a bit of investigation it seems to me like it's just being referenced incorrectly. rather than |
EXPLORER_SCHEMA_EXCLUDE_TABLE_PREFIXES
in https://github.com/groveco/django-sql-explorer/blob/master/README.rst are not complying to the code https://github.com/groveco/django-sql-explorer/blob/622b96354e1d7ae7f7105ae90b8da3247e028623/explorer/app_settings.py#L34-L37