fix bugs in dual #34
Merged
fix bugs in dual #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mosakana
approved these changes
Jul 24, 2024
bpiwowar
commented
Jul 25, 2024
src/xpmir/neural/dual.py
Outdated
| @@ -67,6 +67,13 @@ class Dense(DualVectorScorer[QueriesRep, DocsRep]): | |||
| """A scorer based on a pair of (query, document) dense vectors""" | |||
|
|
|||
| def score_product(self, queries, documents, info: Optional[TrainerContext] = None): | |||
| # logger.info(f'info : {info} \n') | |||
src/xpmir/neural/dual.py
Outdated
| @@ -170,6 +177,13 @@ def __call__(self, info: TrainerContext, queries, documents): | |||
| # Assumes that all weights are positive | |||
| assert info.metrics is not None | |||
|
|
|||
| ##################################################### | |||
There was a problem hiding this comment.
remove the comments
src/xpmir/neural/__init__.py
Outdated
| return TextsRepresentationOutput(torch.cat(list(map(lambda x: x.value, objects))), TokenizedTexts(tokens, ids, lens, mask, token_type_ids)) | ||
|
|
||
|
|
||
| ################################################################################ |
src/xpmir/neural/__init__.py
Outdated
| @@ -92,7 +92,39 @@ def merge(self, objects: Union[DocsRep, QueriesRep]): | |||
|
|
|||
| if isinstance(objects[0], List): | |||
| return list(itertools.chain(objects)) | |||
|
|
|||
| ################################################################################ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.