-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new datasets from ir_datasets #2
Merged
bpiwowar
merged 22 commits into
experimaestro:master
from
MathVast:add-new-datasets-from-ir-datasets
Oct 27, 2023
Merged
Add new datasets from ir_datasets #2
bpiwowar
merged 22 commits into
experimaestro:master
from
MathVast:add-new-datasets-from-ir-datasets
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eries with the train/dev/test sub-version)
This reverts commit adb9e3f.
…m/MathVast/datamaestro_text into add-new-datasets-from-ir-datasets
…m/MathVast/datamaestro_text into add-new-datasets-from-ir-datasets
bpiwowar
requested changes
Oct 26, 2023
@@ -246,3 +297,13 @@ def iter(self) -> Iterator[Tuple[ir.Topic, ir.Document, ir.Document]]: | |||
def count(self): | |||
"""Returns the length or None""" | |||
return self.dataset.docpairs_count() | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the __main__
part
bpiwowar
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new classes for pre-processing and iterating over different datasets from ir_datasets in the context of the Cross-Domain Adaptation project.