-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing a JOSS paper #174
Comments
Hi @dfm, I'm happy to be involved. I've taken a look at the draft. Obviously it's very barebones (following JOSS format), but I think you might want to be a bit more specific in places. I think a little more discussion of the example use cases would be a benefit. So, I think laying the types of measurements that can be included (time-series photometry, time-series radial velocity measurements, and time series position data).
|
Looking over list of comparison packages, here are a few others which I have seen get some use in recent literature (these may be 'trending'): https://github.com/captain-exoplanet/misttborn https://github.com/3fon3fonov/exostriker |
|
|
I'd love to be included, thanks! :D
name: Emily A. Gilbert
orcid: 0000-0002-0388-8004
affiliation: Department of Astronomy and Astrophysics, University of
Chicago, 5640 S. Ellis Ave, Chicago, IL 60637, USA
…On Fri, Apr 23, 2021 at 4:00 PM Tyler Gordon ***@***.***> wrote:
- name: Tyler A. Gordon
orcid: 0000-0001-5253-1987
affiliation:
- Department of Astronomy, University of Washington, Box 351580, U.W., Seattle, WA 98195-1580, USA
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#174 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBMLBVXY4RUDIR7OE3XSB3TKHGV3ANCNFSM43O6EFCA>
.
|
I'd love to be involved, thanks!
|
Hi Dan, happy to be involved, and thank you for developing this awesome tool.
|
Hey Dan, thanks again :) The paper looks good!
|
This looks great, happy to help out any way I can.
|
|
Hey Dan I'd love to be involved here are some v.small comments: Summary
Similar Tools
|
Thanks @christinahedges!
I'll add this - great suggestion!
I'll let @mrtommyb open a PR with a reference to ktransit if he thinks it would be suitable :D
Good point! I'll try to be a little more specific, but I don't want to go into too many details since a detailed comparison would be subtle and beyond the scope. I think I can put in something reasonable! |
@christinahedges I agree with @dfm. The correct dependency is Eric Agol's modification of starry for efficient limb darkening light curves, which is mentioned under the |
Thanks for including me @dfm! This has been a hugely useful tool for me. The paper looks great and I've sent you some really minor comments. I like the comment about stellar variability from @christinahedges too.
|
Thanks, Dan! One request I have is to reference 2017MNRAS.467.1702R for the Kepler solver, for example
|
I've added that reference - thanks @t-brandt! |
JOSS paper looks great to me! Thanks for the invitation
|
Hey team - thanks all for the comments, suggestions, and positive responses. Please feel free to send comments (up until next week: May 5) or add yourself as an author if you haven't already! Re author order, in absence of a better method, I propose that we do: me, @rodluger, and then alphabetical after that. Please let me know (here or offline) if you you have concerns about that proposal or if you have a better idea. I'd be happy to adjust as necessary. If you have already been included as an author, please check the current version of the manuscript to make sure that I got your name and affiliation right. I tried to be careful, but I normalized and rearranged the affiliations a little so I could well have messed it up. If I don't hear from you, I'll expect that you're happy with it. |
|
The pre-review thread for this paper is now open over at JOSS: openjournals/joss-reviews#3256 And it should also be on this evening's ArXiv mailing. I'll email all the co-authors with the ArXiv info when I get it. Thanks all!! |
I've decided to write and submit a JOSS paper for
exoplanet
since the AAS Journals paper that I had been preparing was really taking too long. I'm hoping to write that up some day, but for now I think it's worth having a JOSS paper as a reference in the meantime. I've put together a first rough draft of the manuscript and I think that everything else is pretty much ready to go. So I'd like to open the floor for comments and co-authorship.I'd like to invite everyone who has contributed code so far to
exoplanet
or any of the related projects (@arjunsavel, @rodluger, @iancze, @ericagol, @adrn, @christinahedges, @emilygilbert, @lgbouma, @mrtommyb, @t-brandt, @bmorris3, @barentsen, @jacksonloper, @dylex) to be a co-author (no contribution is too small!). Similarly, if you're seeing this through some other channel, I'd be happy to include anyone else who has made substantive contributions in other ways. Exactly how we'll select the order is TBD (suggestions welcome!) and no pressure if you'd rather not be a co-author.If you would like to be a co-author, please do the following steps before May 5, 2021 or let me know if you need more time:
joss
branch, or as comments hereIf I don't hear from you by May 5, I will follow up with you offline to make sure that you got this message, but please feel free to do this before then :D and let me know if you have any other comments or questions.
The text was updated successfully, but these errors were encountered: