Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Executor and update jni-rs [ECR-3326] #996

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Remove Executor and update jni-rs [ECR-3326] #996

merged 1 commit into from
Jul 10, 2019

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Jul 10, 2019 •
edited
Loading

Overview

Uses Executor from jni-rs. Tests were removed as they now exist in jni-rs

See: https://jira.bf.local/browse/ECR-3326

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.465% when pulling 96022ca on vitvakatu:jni-executor into e2ce7ec on exonum:master.

dmitry-timofeev
dmitry-timofeev approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's lovely to remove code.

@dmitry-timofeev dmitry-timofeev merged commit 6f076b8 into exonum:master Jul 10, 2019
@vitvakatu vitvakatu deleted the jni-executor branch July 10, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-timofeev dmitry-timofeev dmitry-timofeev approved these changes

@skletsun skletsun Awaiting requested review from skletsun

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitvakatu @coveralls @dmitry-timofeev