-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog update for #459, #467 and #469 PRs #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider more specific Move to refactor and to group the changes into one item (with a sublist)
CHANGELOG.md
Outdated
@@ -25,6 +25,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
any changes to the database. The exception includes an error code and an optional | |||
description which the framework saves to the storage for later retrieval. (#392) | |||
- `ListProofValidator` returns an instance of `NavigableMap` instead of `Map`. (#457) | |||
- `exonum-java-proofs` module becomes `exonum-java-binding-common` module | |||
with `com.exonum.binding.common` root package. (#459) | |||
- Refactor`crypto` package to `exonum-java-binding-common` module. (#467) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shan't we go here with a hierarchical lists:
exonum-java-proofs
module becomesexonum-java-binding-common
module:- Move
X
toY
- Move
CHANGELOG.md
Outdated
with `com.exonum.binding.common` root package. (#459) | ||
- Refactor`crypto` package to `exonum-java-binding-common` module. (#467) | ||
- Refactor`hash` package to `exonum-java-binding-common` module. (#469) | ||
- Refactor`Transaction` classes to the new `transaction` package. (#469) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move Transaction
-related classes?
+ double space "to the"
+ no space (here and elsewhere) after "Refactor"
Overview
Changelog updated. Includes changes description after modules refactoring: #459 #467 and #469 PRs