Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update for #459, #467 and #469 PRs #472

Merged
merged 3 commits into from
Sep 12, 2018

Conversation

bullet-tooth
Copy link
Contributor

@bullet-tooth bullet-tooth commented Sep 12, 2018

Overview

Changelog updated. Includes changes description after modules refactoring: #459 #467 and #469 PRs

  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@bullet-tooth bullet-tooth changed the title Changelog update for #457, #467 and #469 PRs Changelog update for #459, #467 and #469 PRs Sep 12, 2018
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider more specific Move to refactor and to group the changes into one item (with a sublist)

CHANGELOG.md Outdated
@@ -25,6 +25,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
any changes to the database. The exception includes an error code and an optional
description which the framework saves to the storage for later retrieval. (#392)
- `ListProofValidator` returns an instance of `NavigableMap` instead of `Map`. (#457)
- `exonum-java-proofs` module becomes `exonum-java-binding-common` module
with `com.exonum.binding.common` root package. (#459)
- Refactor`crypto` package to `exonum-java-binding-common` module. (#467)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shan't we go here with a hierarchical lists:

  • exonum-java-proofs module becomes exonum-java-binding-common module:
    • Move X to Y

CHANGELOG.md Outdated
with `com.exonum.binding.common` root package. (#459)
- Refactor`crypto` package to `exonum-java-binding-common` module. (#467)
- Refactor`hash` package to `exonum-java-binding-common` module. (#469)
- Refactor`Transaction` classes to the new `transaction` package. (#469)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move Transaction-related classes?

+ double space "to the"
+ no space (here and elsewhere) after "Refactor"

@dmitry-timofeev dmitry-timofeev merged commit 68341be into master Sep 12, 2018
@dmitry-timofeev dmitry-timofeev deleted the update_changelog_12.09.18 branch September 12, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants