Extract #getIndexHash in HashableIndex interface [ECR-4064]. #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make SignedMessage public and prevent redundant message serialization in #parseFrom.
Also, remove bad/redundant anchors.
Prevent redundant deserialization.
[skip ci]
[skip ci]
HashableIndex is similar to ObjectHash trait in MerkleDB.
dmitry-timofeev
commented
Jan 16, 2020
| * @see ProofListIndexProxy#getIndexHash() | ||
| * @see ProofMapIndexProxy#getIndexHash() | ||
| * @see ProofEntryIndexProxy#getIndexHash() | ||
| * @see com.exonum.binding.core.storage.indices.HashableIndex |
There was a problem hiding this comment.
The other links are index-specific.
dmitry-timofeev
commented
Jan 16, 2020
| @@ -85,7 +85,8 @@ | |||
| * @param <V> the type of values in this map | |||
| * @see View | |||
| */ | |||
| public final class ProofMapIndexProxy<K, V> extends AbstractIndexProxy implements MapIndex<K, V> { | |||
| public final class ProofMapIndexProxy<K, V> extends AbstractIndexProxy implements MapIndex<K, V>, | |||
There was a problem hiding this comment.
When we make the index factories and add the interfaces for each index type, those interfaces could extend HashableIndex, instead of implementation classes.
bullet-tooth
approved these changes
Jan 17, 2020
|
|
||
| /** | ||
| * Returns the index hash which represents the complete state of this index. | ||
| * Any modifications to the stored entries must affect the index hash. |
There was a problem hiding this comment.
Suggested change
| * Any modifications to the stored entries must affect the index hash. | |
| * Any modifications to the stored entries affects the index hash. |
[skip ci]
dmitry-timofeev
changed the base branch from
add-index-proof-ECR-4011
to
master
vitvakatu
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
HashableIndex is similar to ObjectHash trait in MerkleDB.
See: https://jira.bf.local/browse/ECR-4064
Definition of Done