Support different supervisor modes in exonum-java #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let supervisor_service = supervisor_service(); | ||
| let supervisor_mode = &config | ||
| .run_config | ||
| .node_config |
There was a problem hiding this comment.
Why don't you take node_config from above? And, possibly, move the remaining extraction code inside supervisor_service?
There was a problem hiding this comment.
Because node_config from above isn't config.run_config.node_config. It's exonum core's internal node configuration which does not have supervisor mode option. ECR-4116 created to address API inconvenience that forced this.
added 3 commits
January 14, 2020 16:14
…-supervisor-modes # Conflicts: # exonum-java-binding/core/rust/exonum-java/src/node.rs
dmitry-timofeev
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See: https://jira.bf.local/browse/ECR-XYZ
Definition of Done