Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update time service to dynamic services [ECR-3597] #1136

Merged
merged 9 commits into from
Nov 5, 2019
Merged

Update time service to dynamic services [ECR-3597] #1136

merged 9 commits into from
Nov 5, 2019

Conversation

dmitry-timofeev
Copy link
Contributor

Overview

Update time service to dynamic services:

  • Support multiple instances of time oracle. User must always specify
    the name of the time oracle they intend to use.
  • Use the runtime index to check if the service with the given name
    is active.

See: https://jira.bf.local/browse/ECR-3597

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev
Update time service to dynamic services [ECR-3597]:
faa03c6 
- Support multiple instances of time oracle. User must always specify
the name of the time oracle they intend to use.
- Use the runtime index to check if the service with the given name
is active.
@dmitry-timofeev
Enable checkstyle for time-oracle:
a53c158 
Enable checkstyle and fix style violations.
@dmitry-timofeev dmitry-timofeev added the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label Sep 30, 2019
@dmitry-timofeev
Copy link
Contributor Author

The tests depend on the testkit, otherwise, it must be ready.

MakarovS
MakarovS reviewed Oct 2, 2019
View reviewed changes
exonum-java-binding/time-oracle/src/main/java/com/exonum/binding/time/RuntimeSchema.java Outdated
import com.exonum.binding.core.storage.indices.ProofMapIndexProxy;
import com.exonum.binding.messages.Runtime.InstanceSpec;

class RuntimeSchema {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some description?

exonum-java-binding/time-oracle/src/main/java/com/exonum/binding/time/TimeSchemaProxy.java Outdated Show resolved Hide resolved
@dmitry-timofeev dmitry-timofeev mentioned this pull request Oct 3, 2019
Merged
7 tasks
@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.912% when pulling 8840216 on dmitry-timofeev:update-time-service-ECR-3597 into d2dfb3f on exonum:dynamic-services.

@dmitry-timofeev
Copy link
Contributor Author

Merging as time oracle tests are with #1215 as a 🐔 and 🥚

@dmitry-timofeev dmitry-timofeev merged commit 838db61 into exonum:dynamic-services Nov 5, 2019
@dmitry-timofeev dmitry-timofeev deleted the update-time-service-ECR-3597 branch November 5, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvakatu vitvakatu vitvakatu left review comments

@MakarovS MakarovS MakarovS left review comments

@bullet-tooth bullet-tooth Awaiting requested review from bullet-tooth

Assignees
No one assigned
Labels
work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-timofeev @coveralls @MakarovS @vitvakatu