Add ServiceRuntime#beforeCommit [ECR-3584] #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-timofeev
commented
Sep 27, 2019
| @@ -98,6 +98,21 @@ default void configure(Fork fork, Configuration configuration) { | |||
| */ | |||
| void createPublicApiHandlers(Node node, Router router); | |||
|
|
|||
| /** | |||
| * Handles the changes made by all transactions included in the upcoming block. | |||
There was a problem hiding this comment.
@alekseysidorov would you check please if the user-facing documentation is accurate?
| */ | ||
| void createCheckpoint() { | ||
| public void createCheckpoint() { | ||
| // todo: (1) Are nested rollbacks supported, or is the existing checkpoint lost when a new one |
There was a problem hiding this comment.
Nested rollbacks are not possible, only one checkpoint is available at time.
There was a problem hiding this comment.
OK, I submitted a task to consider to hide this operation, but I had initially misunderstood how it works and the possible consequences: as multiple rollbacks do not reset the state to the initial fork state, changes made by other services won't be affected.
There was a problem hiding this comment.
The new test and the updated documentation must hopefully clarify the things.
Replace the mistakenly imported assertThat method with the main one.
dmitry-timofeev
force-pushed
the
add-before-commit-ECR-3584
branch
from
b17f6dc to
df7cb84
Compare
vitvakatu
approved these changes
Oct 1, 2019
ipenkin
approved these changes
Oct 3, 2019
Also, resolve the todo and improve the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
ServiceRuntime#beforeCommit.See: https://jira.bf.local/browse/ECR-3584
Definition of Done