Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service runtime [ECR-3588] #1131

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Update service runtime [ECR-3588] #1131

merged 5 commits into from
Oct 2, 2019

Conversation

dmitry-timofeev
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev commented Sep 27, 2019 •
edited
Loading

Overview

Update the ServiceRuntime to the newer Runtime specification from the core (as of exonum/exonum@fd3b037).

See: https://jira.bf.local/browse/ECR-3588

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev
Update #initialize and #deploy to work with serialized messages
441d08d 
instead of protobuf.Any.

Also, rename #configureService to #initializeService to not conflict
with service re-configuration.
@dmitry-timofeev
Add ServiceRuntime#isArtifactDeployed
fc00fbf
@dmitry-timofeev
Log invalid deploy arguments
e61ae5f
@dmitry-timofeev
Improve the docs
5fac9c2
@dmitry-timofeev dmitry-timofeev changed the base branch from master to dynamic-services September 27, 2019 15:30
@coveralls
Copy link

coveralls commented Sep 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 85.627% when pulling 597ab93 on dmitry-timofeev:update-service-runtime-ECR-3588 into 3789142 on exonum:dynamic-services.

@dmitry-timofeev dmitry-timofeev merged commit 4b56ff0 into exonum:dynamic-services Oct 2, 2019
@dmitry-timofeev dmitry-timofeev deleted the update-service-runtime-ECR-3588 branch October 2, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvakatu vitvakatu vitvakatu approved these changes

@MakarovS MakarovS MakarovS approved these changes

@ipenkin ipenkin Awaiting requested review from ipenkin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-timofeev @coveralls @MakarovS @vitvakatu