Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setSoaEdit and setSoaEditApi methods to Zone class #98

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Add setSoaEdit and setSoaEditApi methods to Zone class #98

merged 5 commits into from
Mar 14, 2022

Conversation

mvdgeijn
Copy link
Contributor

@mvdgeijn mvdgeijn commented Mar 11, 2022

Description

Added the setSoaEdit and setSoaEditApi methods to the Zone class to be able to set the soa_edit and soa_edit_api domain metadata.

Motivation and context

Doesn't fix an open issue, just adding an extra feature

How has this been tested?

New methods tested on a live PowerDNS server v4.6

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have added the appropriate labels to my pull request (e.g. breaking-change, new-feature, bugfix).
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@mvdgeijn mvdgeijn marked this pull request as draft March 11, 2022 01:21
@mvdgeijn mvdgeijn marked this pull request as ready for review March 11, 2022 01:31
@mvdgeijn
Copy link
Contributor Author

How can I add a label to this PR? The label should be 'new-feature'

@robbinjanssen robbinjanssen added the new-feature New features or options. label Mar 11, 2022
Copy link
Member

@robbinjanssen robbinjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few dots at the end of lines :-)

src/Zone.php Outdated Show resolved Hide resolved
@robbinjanssen robbinjanssen changed the title new setSoaEdit and setSoaEditApi methods in Zone class Add setSoaEdit and setSoaEditApi methods to Zone class Mar 14, 2022
@robbinjanssen robbinjanssen merged commit b4ffdc6 into exonet:master Mar 14, 2022
@robbinjanssen
Copy link
Member

@mvdgeijn tagged as v4.1.0. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants