Enhancement: Add support to list zones #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdpeterson
force-pushed
the
add_list_zones
branch
4 times, most recently
from
a908140 to
fed0eb4
Compare
trizz
added
the
enhancement
trizz
requested changes
Oct 10, 2019
jackdpeterson
force-pushed
the
add_list_zones
branch
from
fed0eb4 to
5750834
Compare
|
Thanks for the review! I just implemented those docblock changes and modified the behavior of getCanoncalName to return the $this->zone. I rebased these two commits down into one to keep your merge history clean as well. |
This change helps facilitate bulks actions like managing ACME from a client-side app. After one calls $powerDns->listZones(); knowing what zone is being returned is extremely helpful. `$zone->getCanonicalName(): string;` PR changes requested by repo owner PHPCS cleanup
jackdpeterson
force-pushed
the
add_list_zones
branch
from
358a1de to
8ab8aa0
Compare
styxit
approved these changes
Oct 16, 2019
trizz
approved these changes
Oct 18, 2019
|
Released as v1.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature enhancement: list domains to support bulk operations.
new method:
Once working with Zone[], knowing what zone is being returned is helpful for consuming code.