Redesign SnmpClient #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,3 +88,6 @@ ENV/ | |||
|
|
|||
| # Rope project settings | |||
| .ropeproject | |||
|
|
|||
| # PyCharm | |||
There was a problem hiding this comment.
I'm curious, what are your code-style settings in PyCharm?
I'm currently using the default PEP8 checks in my code, and, as far as I remember the "max line length" in PyCharm is not set to 79?
I might add some documentation about this.
I'm aware that a short line length can sometimes be super annoying :(
Open
This was referenced Jun 7, 2018
Merged
|
A new major release is out as "pre-release" (at the time of this writing, this is |
|
I will close this as it is out-of-date with the current code-base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved get, walk, and set functions into a new SnmpClient class per discussion in #2.