Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(high-scores): implement #277

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Mar 28, 2023

To-do:

  • example, stub: consider renaming parameter from s
  • config.json: decide on exercise placement
  • example, stub, tests: personalTopThree: consider passing an allocator instead.
  • consider making functions return ?u32
  • consider removing test for init
  • consider removing tests for immutability
  • consider making the scores field an ArrayList, so we can better imagine adding new scores.

@ee7 ee7 requested a review from ErikSchierboom March 28, 2023 12:33
@ee7 ee7 self-assigned this Mar 28, 2023
@ee7 ee7 requested a review from booniepepper September 19, 2023 10:59
@ee7
Copy link
Member Author

ee7 commented Sep 19, 2023

I don't love this exercise as-is. Maybe it'd be better if it was more flexible. See the to-do items for things I'm considering.

@booniepepper
Copy link
Contributor

Personally I think it's reasonable as-is. We can always riff on it in the future if people have feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants