exercises(binary-search): return an optional, not an error union #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `binary-search` required the user to return an error when the array of input items: - was empty - or did not contain the target Return an optional instead, like `std.sort.binarySearch` [1]. Now, an empty input array is just another case of "value not found". Also rename `buffer` to `items` for similar consistency with upstream [1], and to reserve the name `buffer` for a variable that is mutated by a function. [1] https://github.com/ziglang/zig/blob/adc6dec26b8b/lib/std/sort.zig#L10 Refs: exercism#229
ee7
force-pushed
the
exercises-binary-search-return-optional
branch
from
5069d46 to
531ff34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
binary-searchrequired the user to return an error when the array of input items:Return an optional instead, like
std.sort.binarySearch. Now, an empty input array is just another case of "value not found".Also rename
buffertoitemsfor similar consistency with upstream. Elsewhere we have used the namebufferonly for avariable that is mutated by a function.
Refs: #229