exercises(rna-transcription): remove untested RnaError #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
approved these changes
Mar 14, 2023
| allocator.free(rna_slice); | ||
| return RnaError.IllegalDnaNucleotide; | ||
| }, | ||
| else => unreachable, |
There was a problem hiding this comment.
I wonder if this (unreachable) might be good to put in a HINTS.md file?
There was a problem hiding this comment.
Maybe, but unreachable isn't required here. The behavior is just unspecified, in both the instructions and tests.
For example, the user can just return on an unexpected character:
else => return rna_slice,or skip that character, leaving it undefined:
else => continue,or set a placeholder character:
else => rna_slice[i] = '_',For the purposes of an example in this repo, I think unreachable is best - it signals to the maintainer that the behavior is untested.
But yes, I think it's a good idea to add a hint saying that the behavior is unspecified for an unexpected character. I'll do that.
There was a problem hiding this comment.
Done via instructions.append.md: ebab9a1
ee7
force-pushed
the
exercises-rna-transcription-remove-RnaError
branch
from
839eba9 to
ebab9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this exercise, I think this is better than adding a test for invalid input. We have enough exercises that do that. Then this exercise is more focused on practising using an allocator.
Closes: #214
Refs: #229