Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig TDD Exercises #251

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Zig TDD Exercises #251

wants to merge 1 commit into from

Conversation

otherJL0
Copy link

@otherJL0 otherJL0 commented Mar 9, 2023

As discussed in this post, this PR

  • adds a small skipTest() function wrapping the SkipTestError error and
  • adds a call to skipTest() to the top of each test

@otherJL0 otherJL0 changed the title Zig TDD Exercise Zig TDD Exercises Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 9, 2023
@iHiD iHiD reopened this Mar 10, 2023
@iHiD
Copy link
Member

iHiD commented Mar 10, 2023

Thanks :) I've reopened it. There's some internal discussion about this (and skips in general) so it might take be next week until it gets reviewed :)

@ee7
Copy link
Member

ee7 commented Mar 12, 2023

I'm setting this as draft while we discuss, to signal to maintainers that this must not be merged as-is.

Before merging, we'd need to at least:

  1. Alter bin/run-tests so that it removes the skips. At the time of writing, this PR means that CI only tests the first test case for each exercise.
  2. Make the Zig test runner remove the test skips, so that all tests run when using the online editor.
  3. Add skips to exercises that were added after this PR was opened.

I suggest that we don't begin working on any of the above quite yet.

@ee7 ee7 marked this pull request as draft March 12, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants