Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(triangle): simplify error set #218

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Mar 4, 2023

I took an editing pass of the triangle exercise

Closes: #215

@ee7
Copy link
Member

ee7 commented Mar 7, 2023

@ErikSchierboom Any thoughts on what to do here?

@ErikSchierboom
Copy link
Member

which is an argument for just one error name. Otherwise the user has to understand when to return Degenerate, without instruction. If we keep the distinction, I think we should explain in an instructions_append.md.

I think I would prefer just one error name. As your research shows, we removed degenerate from the instructions, so my preference would be to not add it here.

@ee7 ee7 self-assigned this Mar 12, 2023
@ee7 ee7 changed the title exercises(triangle): Editing pass exercises(triangle): simplify error set Mar 12, 2023
@ee7 ee7 merged commit 4a4665a into exercism:main Mar 12, 2023
@ee7
Copy link
Member

ee7 commented Mar 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exercises(triangle): TriangleError.InvalidInequality is a weird name
3 participants